Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve robustness of call log processing #213

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Improve robustness of call log processing #213

merged 2 commits into from
Jan 17, 2025

Conversation

DrPyser
Copy link
Contributor

@DrPyser DrPyser commented Dec 19, 2023 •
edited
Loading

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/aca86b0e47fa4c43ac5301e83da93abc

✔️ tox-linters SUCCESS in 6m 07s
✔️ wazo-tox-py39 SUCCESS in 6m 46s
✔️ debian-packaging-bullseye SUCCESS in 2m 19s
✔️ wazo-tox-integration-call-logd SUCCESS in 14m 02s

@DrPyser DrPyser force-pushed the WAZO-3565-call-log-robust-processing branch from 1121ed9 to 8cf7bfc Compare December 20, 2023 16:41
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/443ef9ad0e6447fe95e389460498bc94

✔️ tox-linters SUCCESS in 3m 56s
✔️ wazo-tox-py39 SUCCESS in 4m 35s
❌ debian-packaging-bullseye NODE_FAILURE Node request 200-0000006025 failed in 0s
❌ wazo-tox-integration-call-logd NODE_FAILURE Node request 200-0000006026 failed in 0s

@DrPyser DrPyser force-pushed the WAZO-3565-call-log-robust-processing branch from 8cf7bfc to 3f2df8b Compare December 22, 2023 14:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/8de6dd248d2d44b5830571f56827eded

✔️ tox-linters SUCCESS in 6m 09s
✔️ wazo-tox-py39 SUCCESS in 6m 19s
✔️ debian-packaging-bullseye SUCCESS in 2m 20s
✔️ wazo-tox-integration-call-logd SUCCESS in 14m 20s

@DrPyser DrPyser force-pushed the WAZO-3565-call-log-robust-processing branch from 3f2df8b to 0d0d7f3 Compare December 9, 2024 21:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/3a61f03efe834803a9fc1430bf66ed03

✔️ tox-linters SUCCESS in 6m 38s
✔️ wazo-tox-py39 SUCCESS in 7m 19s
✔️ debian-packaging-bullseye SUCCESS in 2m 26s
✔️ wazo-tox-integration-call-logd SUCCESS in 16m 51s

@fblackburn1
Copy link
Member

@DrPyser Can you handle this PR? Still useful?

@DrPyser DrPyser force-pushed the WAZO-3565-call-log-robust-processing branch from 0d0d7f3 to 4cbdbf7 Compare January 16, 2025 19:56
@DrPyser
Copy link
Contributor Author

DrPyser commented Jan 16, 2025

@DrPyser Can you handle this PR? Still useful?

Yeah I think that's still valuable. From memory I did this when addressing support requests involving call logs, and problematic CELs were making it impossible to re-generate call logs.

A test scenario would involve poisoning a sequence of CELs with bad data/missing data in a way that triggers an error in the processing, but simultnaeously processing unrelated CELs. The unrelated CELs should be processed correctly.
That can be tested in unit or integration tests.

@DrPyser
Copy link
Contributor Author

DrPyser commented Jan 16, 2025

The specific error paths that were present at the time have been fixed I think(https://wazo-dev.atlassian.net/browse/WAZO-3545). But other error paths may remain, and error paths may be introduced in the future.

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/37c3298c8af24c5dbc1d980ea71c2545

✔️ tox-linters SUCCESS in 6m 25s
✔️ wazo-tox-py39 SUCCESS in 7m 10s
✔️ debian-packaging-bullseye SUCCESS in 2m 10s
✔️ wazo-tox-integration-call-logd SUCCESS in 15m 37s

@DrPyser
tests: added scenario for resilient multi-call processing
338a487 
check that a bad apple won't spoil the lot
@DrPyser
Copy link
Contributor Author

DrPyser commented Jan 16, 2025

Added a test scenario to cover this

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
37.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/301f61f9c42c46d49ca5c2f57d67c332

✔️ tox-linters SUCCESS in 6m 20s
✔️ wazo-tox-py39 SUCCESS in 7m 04s
✔️ debian-packaging-bullseye SUCCESS in 2m 11s
✔️ wazo-tox-integration-call-logd SUCCESS in 15m 12s

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://zuul.wazo.community/zuul/t/local/buildset/019a543030904a9ea0d2fa287f7fb50f

✔️ tox-linters SUCCESS in 6m 20s
✔️ wazo-tox-py39 SUCCESS in 7m 03s
✔️ debian-packaging-bullseye SUCCESS in 2m 38s
✔️ wazo-tox-integration-call-logd SUCCESS in 18m 16s

@wazo-community-zuul wazo-community-zuul bot merged commit 831b339 into master Jan 17, 2025
3 of 4 checks passed
@wazo-community-zuul wazo-community-zuul bot deleted the WAZO-3565-call-log-robust-processing branch January 17, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fblackburn1 fblackburn1 fblackburn1 approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrPyser @fblackburn1